Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Use js-packages/components IconTooltip #39867

Merged
merged 13 commits into from
Nov 15, 2024

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Oct 22, 2024

Description

Replace custom IconTooltip implementation with js-packages version

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Checkout this branch and refer to views in the screenshots below
    • FirewallHeader pre-upgrade and post-downgrade with outdated automatic rules enabled
    • PaidAccordion when a fixer is stale (to be removed shortly)
  • Ensure the popover handles and displays correctly
  • Ensure no regressions are introduced

Screenshots

FirewallHeader:
Screen Shot on 2024-10-22 at 11-23-49

PaidAccordion:
Screen Shot on 2024-10-22 at 11-14-49

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/protect/icon-tooltip-use branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/protect/icon-tooltip-use
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/protect/icon-tooltip-use
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [JS Package] Components [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress RNA labels Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dkmyta dkmyta marked this pull request as ready for review October 22, 2024 18:25
Base automatically changed from update/components/threats-data-view-icon-tooltip-use to add/components/threats-data-view October 24, 2024 22:20
@nateweller nateweller force-pushed the add/components/threats-data-view branch 18 times, most recently from 388600f to 25fb234 Compare October 26, 2024 00:05
@nateweller nateweller requested a review from a team October 28, 2024 00:29
@dkmyta dkmyta requested a review from nateweller October 28, 2024 16:59
@nateweller nateweller force-pushed the add/components/threats-data-view branch 8 times, most recently from 0a1b0bd to 58f6f3e Compare October 29, 2024 20:24
@nateweller nateweller force-pushed the add/components/threats-data-view branch 3 times, most recently from 25254f3 to 79804d5 Compare November 5, 2024 21:58
Base automatically changed from add/components/threats-data-view to trunk November 6, 2024 16:33
@dkmyta dkmyta merged commit afe4ad8 into trunk Nov 15, 2024
71 of 72 checks passed
@dkmyta dkmyta deleted the update/protect/icon-tooltip-use branch November 15, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants